1 May
2020
1 May
'20
10:38 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32989 )
Change subject: mb/pcengines/apu2: Describe serial ports in ACPI ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/32989/3/src/mainboard/pcengines/apu... PS3, Line 19: I
Wow, sorry for the lack of follow up here: If the generic code works, use that. […]
I'd prefer to have this ASL code under the superio/ scope. Maybe use another SIO as an example
--
To view, visit https://review.coreboot.org/c/coreboot/+/32989
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0de4172a1884abbe9d625060a9045c9d71469e27
Gerrit-Change-Number: 32989
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 May 2020 08:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Georgi pgeorgi@google.com
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment