Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45376 )
Change subject: soc/intel/xeon_sp/cpx: find IIO_UDS HOB once when creating DMAR table ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... File src/soc/intel/xeon_sp/cpx/acpi.c:
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 608: This is one test and could only have a single return point or keep the get stack for port function as Angel noted above.
if (port == 0 ...) || (port >= 2a ...) || .... return 0
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 615: 0xffffffff Should this check for an expected DEVID instead of just checking if a device is present?
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 620: true This derefrences a nullptr. You need to check it for NULL. Maybe use a different way to track "first".
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 702: Try to use the enums consistently p = PSTACK0
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 764: 0 Try to use the enums consistently p = PSTACK0
https://review.coreboot.org/c/coreboot/+/45376/2/src/soc/intel/xeon_sp/cpx/a... PS2, Line 765: 0 PSTACK0