Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56037 )
Change subject: util/abuild: Check if buildtest configurations having invalid options ......................................................................
util/abuild: Check if buildtest configurations having invalid options
Change-Id: I83a316dad31f8567fad68171b68ee546bfe548f0 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M util/abuild/abuild 1 file changed, 20 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/56037/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index dc3670b..0084d2a 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -446,6 +446,25 @@ check_config "$build_dir" "vendor" "CONFIG_VENDOR_$(mainboard_vendor "${MAINBOARD}")=y" local VENDOR_OK=$?
+ local CONFIG_OK=0 + if [ -f $config_file ]; then + echo $config_file + for config in $(sed -n '/^CONFIG_.*=.*/p' $config_file); do + check_config "$build_dir" "config option" $config + if [ $? -ne 0 ]; then + echo $config "set incorrectly" + CONFIG_OK=$? + fi + done + for config in $(sed -n 's/# (CONFIG.*) is not set/\1/p' $config_file); do + check_config "$build_dir" "config option" $config"=y" negate + if [ $? -ne 0 ]; then + echo $config "set incorrectly" + CONFIG_OK=$? + fi + done + fi + if [ "$chromeos" = false ]; then # Skip this rule for configs created from templates that already # come with CHROMEOS enabled. @@ -456,7 +475,7 @@ local FORCE_ENABLED_CROS=0 fi
- if [ $BUILDENV_CREATED -ne 0 ] || [ $MAINBOARD_OK -ne 0 ] || [ $VENDOR_OK -ne 0 ] || [ $FORCE_ENABLED_CROS -eq 1 ]; then + if [ $BUILDENV_CREATED -ne 0 ] || [ $MAINBOARD_OK -ne 0 ] || [ $VENDOR_OK -ne 0 ] || [ $FORCE_ENABLED_CROS -eq 1 ] || [ $CONFIG_OK -ne 0 ]; then junit " <testcase classname='board${testclass/#/.}' name='$BUILD_NAME' >"
junit "<failure type='BuildFailed'>"