[coreboot-gerrit] Change in ...coreboot[master]: inteltool: Move GPIOs to c files per platform

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31504 )

Change subject: inteltool: Move GPIOs to c files per platform
......................................................................

Patch Set 37:

(2 comments)

https://review.coreboot.org/#/c/31504/34/util/inteltool/gpio.h 
File util/inteltool/gpio.h:

PS34:
> No specific reason. Both seperated seems a bit small to me, but not really a problem.

Maybe move the `gpio_group` definitions into platform.h?

https://review.coreboot.org/#/c/31504/34/util/inteltool/platform_apollolake.... 
File util/inteltool/platform_apollolake.h:

PS34:
> What is a compilation unit? I want to implement more registers in the future, so they will also be i […]

Compilation unit is what the compiler sees after preprocessing, i.e.
a .c file with all its includes.

I think it makes sense to gather all the definitions in a single
`platform.h`.