build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46336 )
Change subject: soc/intel/broadwell: Guard MCHBAR macro parameters ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... File src/soc/intel/broadwell/include/soc/systemagent.h:
https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... PS4, Line 83: #define MCHBAR8(x) *((volatile u8 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... PS4, Line 84: #define MCHBAR16(x) *((volatile u16 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/46336/4/src/soc/intel/broadwell/inc... PS4, Line 85: #define MCHBAR32(x) *((volatile u32 *)(MCH_BASE_ADDRESS + (x))) Macros with complex values should be enclosed in parentheses