Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39941 )
Change subject: soc/intel/broadwell: add ACPI backlight support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39941/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39941/1//COMMIT_MSG@11 PS1, Line 11: to match prototypes in i915.h and avoid conflicts. `drivers/intel/gma/intel_ddi.c` seems to be the only reason to export these functions... maybe we should just merge it into haswell/, its only user.
https://review.coreboot.org/c/coreboot/+/39941/1/src/soc/intel/broadwell/igd... File src/soc/intel/broadwell/igd.c:
https://review.coreboot.org/c/coreboot/+/39941/1/src/soc/intel/broadwell/igd... PS1, Line 640: } Not sure if we need a separate function?
https://review.coreboot.org/c/coreboot/+/39941/1/src/soc/intel/broadwell/igd... PS1, Line 642: device Pass `device` on?