Hello EricR Lai, Simon Glass, Paul Menzel, Duncan Laurie, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37455
to look at the new patch set (#2).
Change subject: libpayload/drivers/i8042: If configured ignore all i8042 init failures ......................................................................
libpayload/drivers/i8042: If configured ignore all i8042 init failures
There are keyboards that do not respond properly to init command but are still usable. The flag LP_PC_KEYBOARD_IGNORE_INIT_FAILURE was added to ignore init failures on boards where this issue happens. coreboot:23584 added another init command without checking that the flag was not set so Drallion boards will sometimes return an error when this init command is sent causing the keyboard driver to not be added and then the keyboard does not work.
This change standardizes the keyboard init logic to ensure that: 1. The ignore init failure flag is always checked 2. Error messages are always printed if an command fails (and the init failure flag is not set) in a standard fashion 3. The proper named command is used
BUG=b:145130110 TEST=Draillion keyboard is usable on every boot.
Change-Id: Ifb1c908b11afb8098a6cbbfa8a3d4391cabacd0f Signed-off-by: Mathew King mathewk@chromium.org --- M payloads/libpayload/drivers/i8042/keyboard.c 1 file changed, 14 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/37455/2