[coreboot-gerrit] Change in coreboot[master]: soc/intel/xeon_sp: Add common chip.h

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45969 )

Change subject: soc/intel/xeon_sp: Add common chip.h
......................................................................

Patch Set 2: Code-Review+1

(3 comments)

https://review.coreboot.org/c/coreboot/+/45969/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45969/2//COMMIT_MSG@11 
PS2, Line 11: call
include? use?

https://review.coreboot.org/c/coreboot/+/45969/2//COMMIT_MSG@11 
PS2, Line 11: call
same here

https://review.coreboot.org/c/coreboot/+/45969/2/src/soc/intel/xeon_sp/chip.... 
File src/soc/intel/xeon_sp/chip.h:

https://review.coreboot.org/c/coreboot/+/45969/2/src/soc/intel/xeon_sp/chip.... 
PS2, Line 10: endif
            : 
            : #if
nit: elif