Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33052 )
Change subject: util/smctool: A tool for reading Apple SMC keys ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33052/4/util/smctool/Makefile File util/smctool/Makefile:
https://review.coreboot.org/c/coreboot/+/33052/4/util/smctool/Makefile@16 PS4, Line 16: CC = gcc One would like to be able to override CC=gcc (with CC=clang), so please adjust this to read 'CC ?= gcc'.
https://review.coreboot.org/c/coreboot/+/33052/4/util/smctool/smctool.c File util/smctool/smctool.c:
https://review.coreboot.org/c/coreboot/+/33052/4/util/smctool/smctool.c@20 PS4, Line 20: endian This include isn't portable, please surround it with '#ifdef (__FreeBSD__) #include <sys/endian.h> #else ... #endif'