Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33859 )
Change subject: Kconfig: Enable RAMPAYLOAD for x86
......................................................................
Patch Set 3:
It's a huge fundamental change you are pushing through with RAMPAYLOAD.
I am not so happy about this being submitted with the little discussion review it saw. Mostly I feel some amount of boilerplate KConfig variables has been added just before release and without documentation. Other people may feel otherwise who have thoroughly reviewed this work...
Why is RAMPAYLOAD=y correct default? Isn't a board still initially developed to go through the standard ramstage, or does HAVE_RAMPAYLOAD=y imply that RAMPAYLOAD=n for a board might not even work?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33859
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40308bbf970a0dbe5f7e2086ed8a7a70c2a3a32c
Gerrit-Change-Number: 33859
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jul 2019 03:06:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
