[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Use SMU to put system into S3

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41626 )

Change subject: soc/amd/picasso: Use SMU to put system into S3
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41626/2/src/soc/amd/picasso/smihand... 
File src/soc/amd/picasso/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41626/2/src/soc/amd/picasso/smihand... 
PS2, Line 214: BIOS_ERR
> Even `BIOS_EMERG`?

i'd keep BIOS_ERR. sure, it's a "that shouldn't have happened" type of situation but it's not as fatal as for example no RAM found