Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47800 )
Change subject: soc/mediatek/mt8192: add i2c driver support
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47800/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47800/6//COMMIT_MSG@9
PS6, Line 9: Add i2c controller driver code for mt8192, with the apdma remove
: hand-shake signal, it requirs special operation timing to reset
: i2c manually.
What about this:
Add I2C controller for MT8192, and revised the common I2C driver
to support I2C controller running in APDMA async mode. In that
case we have to initiate a different handshake protocol and reset
I2C differently.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13835e00eb674a93aa5496a9870d1e601e263368
Gerrit-Change-Number: 47800
Gerrit-PatchSet: 6
Gerrit-Owner: wang qii
Qii.Wang@mediatek.com
Gerrit-Reviewer: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Nov 2020 07:37:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment