Attention is currently required from: Felix Singer, Furquan Shaikh, Martin Roth, Tim Wawrzynczak, Angel Pons, Subrata Banik.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52789 )
Change subject: soc/intel/skylake: Drop EXCLUDE_NATIVE_SD_INTERFACE
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/skylake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/52789/comment/d35ec6e6_c8c4cb22
PS5, Line 120: 0x4c4
Did you confirm that the mainboards do not use these GPIOs for some other purpose? Else, it would be […]
That's an interesting thought. My understanding was that with the _ADR
above this "Device" would only be treated as present if it matches an
enumerated PCI device in the OS. The spec calls this an augmented device
descriptor. But it doesn't mention what that implies.
Would the OS try to switch power states of a PCI device that it can't see?
What I could find in the description of _STA:
"If a device object describes a device that is not on an enumerable bus
and the device object does not have an _STA object, then OSPM assumes
that the device is present, enabled, shown in the UI, and functioning."
I always interpreted this that we can expect for a PCI device that the OS
is supposed to check its presence. But I couldn't find more details about
it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id07f59b5252cf3862724d6ff3d7c54d51ccfd9a6
Gerrit-Change-Number: 52789
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Mon, 03 May 2021 22:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment