Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39690 )
Change subject: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variables in romstage ......................................................................
Patch Set 8:
(3 comments)
Thanks!
https://review.coreboot.org/c/coreboot/+/39690/8/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/romstage.c:
https://review.coreboot.org/c/coreboot/+/39690/8/src/mainboard/ocp/tiogapass... PS8, Line 79: } Why not just return from here? In this case, we do not need if (enable) {..} after this.
https://review.coreboot.org/c/coreboot/+/39690/8/src/mainboard/ocp/tiogapass... PS8, Line 84: printk(BIOS_DEBUG, "FRB2 timer countdown set to: %d\n", Let's print out time unit here as well.
https://review.coreboot.org/c/coreboot/+/39690/8/src/mainboard/ocp/tiogapass... PS8, Line 99: init_frb2_wdt(); If BMC is not up, we need to skip BMC interaction, including WDT initialization.