Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39678 )
Change subject: mb/google/deltaur: Provide initial devicetree ......................................................................
Patch Set 3:
(13 comments)
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 36: OC0
skip
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 37: OC0
skip
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 38: JUSB1
Ext USB Port 1
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 38: OC1
OC0
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 39: JUSB2
Ext USB Port 2
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 47: Type-C Port 1
Ext USB Port 1
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 48: OC0
ports[1] and OC1
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 48: Type-C Port 2
Ext USB Port 2
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 53: 0
Should be 1?
Done
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 73: register "PcieClkSrcUsage[6]" = "PCIE_CLK_NOTUSED"
I think you miss 7 here.
There are only 7 total, so max index of 6, see https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/tigerlake/K...
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 99: .speed = I2C_SPEED_FAST,
TPM need early_init = 1, right?
Whoops, accidentally put it on i2c2, will move.
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 236: end
Do we need device usb 3. […]
Yes, will add.
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 277: device pci 1c.7 on end # PCIe Root Port #8 (LAN)
chip drivers/net […]
Done