Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32322 )
Change subject: soc/intel/cannonlake: Add null refrence check for Cnvi
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32322/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32322/3//COMMIT_MSG@8
PS3, Line 8:
Was this reported by coverity?
https://review.coreboot.org/#/c/32322/3/src/soc/intel/cannonlake/fsp_params....
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/#/c/32322/3/src/soc/intel/cannonlake/fsp_params....
PS3, Line 258: IS_ENABLED(CONFIG_SOC_INTEL_COMETLAKE)
IS_ENABLED has been deprecated. Please use CONFIG(SOC_INTEL_COMETLAKE) instead like it was before.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32322
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e1011d9ac93ed764b6c2aa425928a972ec2aa43
Gerrit-Change-Number: 32322
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 15 Apr 2019 05:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment