Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42302 )
Change subject: mb/google/volteer/var/terrador: Update gpio setting and overridetree.cb ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42302/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42302/4/src/mainboard/google/voltee... PS4, Line 28: probe the max98373 and alc5682i are on the MLB, right? in that case, there's no need for "probe" - the devices are always present. you won't need to use the audio DB field in fw_config.
https://review.coreboot.org/c/coreboot/+/42302/4/src/mainboard/google/voltee... PS4, Line 53: chip drivers/generic/max98357a : register "hid" = ""MX98357A"" : register "sdmode_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_F18)" : register "sdmode_delay" = "5" : device generic 0 on : probe AUDIO MAX98357_ALC5682I_I2S : end : end : chip drivers/intel/soundwire : device generic 0 on : probe AUDIO MAX98373_ALC5682_SNDW : chip drivers/soundwire/alc5682 : # SoundWire Link 0 ID 1 : register "desc" = ""Headset Codec"" : device generic 0.1 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 3 : register "desc" = ""Left Speaker Amp"" : device generic 1.3 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 7 : register "desc" = ""Right Speaker Amp"" : device generic 1.7 on end : end : end : end i didn't see any of these devices on your schematics. remove? leave 1f.3 enabled.