[coreboot-gerrit] [M] Change in coreboot[master]: WIP acpi: Add SPCR table

[Arthur Heymans (Code Review)]

Attention is currently required from: Benjamin Doron, Lance Zhao, Nico Huber, Tim Wawrzynczak.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email )

Change subject: WIP acpi: Add SPCR table
......................................................................

Patch Set 3:

(2 comments)

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/75685/comment/a5776b0a_018f2f65 :
PS3, Line 1842: 	/* 16550 compatible, TODO do we need others? */
> Maybe:
> if (!CONFIG(CONSOLE_SERIAL))
>        return;

Sounds good.

https://review.coreboot.org/c/coreboot/+/75685/comment/17ba0c3d_8ab3eb20 :
PS3, Line 1870: 	/* TODO: provide callback for IRQ on non standard ports*/
> Would it be bad not to use an IRQ at all?

Probably best indeed.