Attention is currently required from: Ravi kumar, mturney mturney.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47077 )
Change subject: sc7280: Add GPIO driver in coreboot
......................................................................
Patch Set 16:
(1 comment)
File src/soc/qualcomm/sc7280/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/47077/comment/501bd2ab_12f41bb0
PS16, Line 92: #define PIN(index, func1, func2, func3, func4) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47077
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibefa2fc04db09f1837f65f5a6d4b8534df040785
Gerrit-Change-Number: 47077
Gerrit-PatchSet: 16
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Thu, 18 Mar 2021 05:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment