Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78428?usp=email )
Change subject: soc/amd/stoneyridge: Use common block graphics driver
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/78428/comment/b26aee93_0a922e0a :
PS6, Line 182: #if CONFIG(RUN_FSP_GOP)
I just stumbled upon this. Why the change to pp if?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78428?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I260b964be59c1a208ff907c474243a9ace03f206
Gerrit-Change-Number: 78428
Gerrit-PatchSet: 6
Gerrit-Owner: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 18 Oct 2023 05:35:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment