Krishna P Bhat D has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )
Change subject: mb/google/hatch: Update GPIO settings
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32176/7/src/mainboard/google/hatch/variants/...
PS7, Line 342: PLTRST
Probably because it was triggering interrupt storm when booting from S5?
I haven't checked the interrupt storm. I have verified with pad reset config set to DEEP for SD_CD# on hatch proto, we observe that the system waits for few seconds at "Starting kernel" and then resets, when we press the power button before the system enters G3. However, this issue is not observed on hatch EVT. This appears like a proto specific board issue.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 7
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 May 2019 06:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment