Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35900 )
Change subject: mb/*/*/gpio: Remove null-initialized members
......................................................................
Patch Set 2: Code-Review-1
for the NATIVE/GPIO, sure
For INPUT/OUTPUT and certainly for HIGH/LOW on OUTPUT I don't think this is an improvement. For NO_INVERT, NO_BLINK and RESET_PWROK, I also think it's fine.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2799293585bcfcf41c93a9dbe358cd806f9374f5
Gerrit-Change-Number: 35900
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Oct 2019 11:57:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment