Attention is currently required from: Jakub Czapiga, Paul Menzel, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75999?usp=email )
Change subject: soc/intel/meteorlake: Rename shared SRAM aliases
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75999/comment/a342e0f7_235c66e8 :
PS2, Line 7: sram
nit: `SRAM`. […]
Done
https://review.coreboot.org/c/coreboot/+/75999/comment/5567bd30_53af8735 :
PS2, Line 9: share
share*d*?
Done
https://review.coreboot.org/c/coreboot/+/75999/comment/1ed6a00e_0b75fc31 :
PS2, Line 9: Rename share sram aliases for IOE and PMC to make them
: more readable.
Fits in one line (72 characters).
Done
https://review.coreboot.org/c/coreboot/+/75999/comment/308288be_81399bee :
PS2, Line 11:
Maybe explicitly list the old/new keywords: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75999?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02a8cacc075f396549703d7a008382e76258f865
Gerrit-Change-Number: 75999
Gerrit-PatchSet: 3
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 22 Jun 2023 22:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment