Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42786 )
Change subject: mb/amd: Add Pollock CRB Cereme as Mandolin variant
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42786/12/src/mainboard/amd/mandolin...
File src/mainboard/amd/mandolin/Kconfig:
https://review.coreboot.org/c/coreboot/+/42786/12/src/mainboard/amd/mandolin...
PS12, Line 120: default 5
Cereme uses the W74M12JW chip, which supports quad IO @66MHz, so I think this should be fine. […]
when Matt tested the patch maybe 2 weeks ago, it worked when EM100 was selected, but not if it wasn't even though he tested it with a flash chip and not with the EM100. not sure if this or the devicetree setting is the problem. I can only test the Mandolin + EM100 case, so that one works; don't have a Cereme or an 1.8V flasher
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief8a05b0a360563d26a81941720b78014feb0d25
Gerrit-Change-Number: 42786
Gerrit-PatchSet: 19
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 15:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment