Attention is currently required from: Patrick Rudolph, Arthur Heymans, Aaron Durbin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52784 )
Change subject: arch/x86: Fix !CONFIG_VBOOT_SEPARATE_VERSTAGE ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52784/comment/0dc1108a_21f46430 PS1, Line 7: arch/x86: Fix !CONFIG_VBOOT_SEPARATE_VERSTAGE
What was broken, exactly?
So I just did the test:
/home/usuario/coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: build/bootblock/cpu/x86/reset16.o: in function `_start': (.reset+0x0): multiple definition of `_start'; build/bootblock/arch/x86/assembly_entry.o:/home/usuario/coreboot/src/arch/x86/assembly_entry.S:32: first defined here
So, please update the commit message:
arch/x86: Fix building with !VBOOT_SEPARATE_VERSTAGE
or:
arch/x86: Fix building with CONFIG_VBOOT_SEPARATE_VERSTAGE=n