build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 )
Change subject: amd/common/psp: Remove use of PspBaseLib
......................................................................
Patch Set 20:
(3 comments)
https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c@...
PS20, Line 78: }
void function return statements are not generally useful
https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c@...
PS20, Line 80: static uintptr_t get_psp_bar3_addr( void )
space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/27619/20/src/soc/amd/common/block/psp/psp.c@...
PS20, Line 80: static uintptr_t get_psp_bar3_addr( void )
space prohibited before that close parenthesis ')'
--
To view, visit
https://review.coreboot.org/27619
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a
Gerrit-Change-Number: 27619
Gerrit-PatchSet: 20
Gerrit-Owner: Charles Marslett
charles.marslett@amd.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Charles Marslett
charles.marslett@amd.corp-partner.google.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@se-eng.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 22 Sep 2018 09:29:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No