Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42413 )
Change subject: cpu/intel/206ax/acpi.c: Fix get_cores_per_package ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42413/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42413/3//COMMIT_MSG@20 PS3, Line 20: Related to #29669. Please use the Change-Id as reference, so Gerrit marks it up as a link.
https://review.coreboot.org/c/coreboot/+/42413/3/src/cpu/intel/model_206ax/a... File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/42413/3/src/cpu/intel/model_206ax/a... PS3, Line 21: logical_cores = msr.lo & 0xffff; Excuse my ignorance, but why is the `& 0xffff` needed?
typedef struct msr_struct { unsigned int lo; unsigned int hi; } msr_t;