[coreboot-gerrit] [S] Change in coreboot[main]: mb/samsung/stumpy: Use CFR setup menu to manage options

[Matt DeVillier (Code Review)]

Attention is currently required from: Angel Pons.

Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87404?usp=email )

Change subject: mb/samsung/stumpy: Use CFR setup menu to manage options
......................................................................

Patch Set 2:

(1 comment)

File src/mainboard/samsung/stumpy/Kconfig:

https://review.coreboot.org/c/coreboot/+/87404/comment/2692b6c8_b2afecef?usp... :
PS2, Line 35: config UEFI_CFR_SYSTEM_OPTIONS
            : 	bool "Use UEFI setup menu to manage system configuration"
            : 	select DRIVERS_EFI_VARIABLE_STORE
            : 	select DRIVERS_OPTION_CFR
            : 	select UDK_2017_BINDING
            : 	default y if PAYLOAD_EDK2 && SMMSTORE
            : 	default n
            :
> Ideally, this should be set up so that selecting CFR as the option backend would select these. […]

the UDK binding is needed for non-FSP platforms in order for  some necessary headers to be included - I don't think we'd want that selected by default since all FSP platforms select a specific UDK binding.