Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37840 )
Change subject: [WIP] mb/**/hda_verb.{c,h}: Clean up remaining files ......................................................................
Patch Set 1:
(28 comments)
It builds? Really?
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/buddy/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/auron/... PS1, Line 22: 14 13, you doofus
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/mccloud/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/monroe/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/panther/hda_verb.c:
PS1: removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/tricky/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/beltin... File src/mainboard/google/beltino/variants/zako/hda_verb.c:
PS1: swap of NID 0x18 and 0x19
removal of guards on .c
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 64: UaJ s/UaJ/UAJ
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 70: db s/db/dB
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 76: front s/front/Front
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 82: back s/back/Back
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 82: boost s/boost/Boost
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 100: dVdd s/dVdd/DVDD
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 100: I2c s/I2c/I2C
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 112: eQ s/eQ/EQ
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/dralli... PS1, Line 112: disable s/disable/Disable
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... File src/mainboard/google/link/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... PS1, Line 77: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/link/h... PS1, Line 112: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/parrot... File src/mainboard/google/parrot/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/parrot... PS1, Line 127: 0x0 uncorrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... File src/mainboard/google/stout/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... PS1, Line 24: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/google/stout/... PS1, Line 70: NID 0x01, kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... File src/mainboard/intel/coffeelake_rvp/variants/cfl_h/include/variant/hda_verb.h:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 128: MIc2 s/MIc2/MIC2
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 140: LINe2 s/LINe2/LINE2
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/coffeel... PS1, Line 176: Mic2 s/Mic2/MIC2
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/emerald... File src/mainboard/intel/emeraldlake2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/emerald... PS1, Line 51: 0x3 corrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/wtm2/hd... File src/mainboard/intel/wtm2/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/intel/wtm2/hd... PS1, Line 52: 0x3 corrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/kontron/ktqm7... File src/mainboard/kontron/ktqm77/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/kontron/ktqm7... PS1, Line 101: 0x0 uncorrected bad index
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/lenovo/x131e/... File src/mainboard/lenovo/x131e/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/lenovo/x131e/... PS1, Line 65: 0x80860101 kill
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/samsung/stump... File src/mainboard/samsung/stumpy/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/37840/1/src/mainboard/samsung/stump... PS1, Line 51: 0x3 corrected bad index