9 Apr
2020
9 Apr
'20
2:58 a.m.
Daniel Kurtz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/2/src/mainboard/google/hatch/... PS2, Line 146: VBOOT_EARLY_EC_SYNC I get LID_SWITCH, but it is not immediately clear to me why VBOOT_EARLY_EC_SYNC is restricted to only for laptop form factors. Can you add a quick comment here or in the commit message?
--
To view, visit https://review.coreboot.org/c/coreboot/+/40252
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15dc9efa51e9d61297868df287879dfb62909e33
Gerrit-Change-Number: 40252
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Sam McNally sammc@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Stefan Reinauer reinauer@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Andrew McRae amcrae@chromium.org
Gerrit-CC: Daniel Kurtz djkurtz@google.com
Gerrit-CC: Kangheui Won khwon@chromium.org
Gerrit-CC: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 00:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment