[coreboot-gerrit] Change in coreboot[master]: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variable...

[Andrey Petrov (Code Review)]

Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39690 )

Change subject: mb/ocp/tiogapass: Configure IPMI FRB2 watchdog timer via VPD variables in romstage
......................................................................

Patch Set 15: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/39690/15/src/mainboard/ocp/tiogapas... 
File src/mainboard/ocp/tiogapass/romstage.c:

https://review.coreboot.org/c/coreboot/+/39690/15/src/mainboard/ocp/tiogapas... 
PS15, Line 75: 	if (vpd_get_bool(FRB2_TIMER, VPD_RW, &enable)) {
             : 		if (!enable) {
             : 			printk(BIOS_DEBUG, "Disable FRB2 timer\n");
             : 			ipmi_stop_bmc_wdt(BMC_KCS_BASE);
             : 			return;
             : 		}
             : 	}
> It's according to the BIOS requirement, it says before MP, the default setting is enabled but no act […]

ah ok, thanks for clarification