[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... 
File src/soc/intel/common/block/cpu/car/exit_car.S:

https://review.coreboot.org/c/coreboot/+/48286/18/src/soc/intel/common/block... 
PS18, Line 94: 	/* Reset CLOS selector to 0 */
             : 	mov	$IA32_PQR_ASSOC, %ecx
             : 	rdmsr
             : 	and	$~IA32_PQR_ASSOC_MASK, %edx
             : 	wrmsr
> If we make following change, COS_MAPPED_TO_MSB has to be selected for all the programs. Right? […]

It's selected for JSL & TGL right now. When COS_MAPPED_TO_MSB is set, then we use bits 32 & 33 for setting the CLOS selector, otherwise (COS_MAPPED_TO_MSB is not set) it's bits 0 and 1 (https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...), so the teardown code should clear the correct set of bits.