[coreboot-gerrit] Change in coreboot[master]: lib/cbfs: Add fallback to RO region to cbfs_boot_locate

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36545 )

Change subject: lib/cbfs: Add fallback to RO region to cbfs_boot_locate
......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/c/coreboot/+/36545/6/src/lib/cbfs.c 
File src/lib/cbfs.c:

https://review.coreboot.org/c/coreboot/+/36545/6/src/lib/cbfs.c@68 
PS6, Line 68: 		/* When VBOOT_ENABLE_CBFS_FALLBACK is enabled and a file is not available in the
Correct long-form multi-line comment style is

/* 
  * text
  * text
  */

(FWIW, I'm not sure you need such a huge explanation inline here, explaining the details in the Kconfig help string should be good enough.)

https://review.coreboot.org/c/coreboot/+/36545/6/src/lib/cbfs.c@78 
PS6, Line 78: CBFS_BOOT_LOCATE: 
nit: use __func__ if you want to output the function name, but the other code here doesn't do that either so I'm not sure why you'd want to do it here. Maybe print the file name instead? That could actually be useful for users...