Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42064 )
Change subject: soc/amd/picasso: Split i2c implementation for psp_verstage ......................................................................
Patch Set 12:
(4 comments)
I prefer an approach of guarding the sections with ENV_X86 instead of forking the file and that you would rebase work on tree with CB:42523 applied. In my opinion you need to be able to build psp-verstage without the x86-centric #defines of various base addresses.
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 4: #include <acpi/acpi.h> unrelated
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 11: #include <soc/iomap.h> needed
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 12: #include <soc/pci_devs.h> unrelated
Could have been done earlier with config_of_soc() change I believe.
https://review.coreboot.org/c/coreboot/+/42064/12/src/soc/amd/picasso/i2c.c@... PS12, Line 51: case APU_I2C2_BASE: from <soc/iomap.h>