Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47602 )
Change subject: [WIP] lib/version: Remove .id section and id.S files ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47602/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47602/3//COMMIT_MSG@17 PS3, Line 17: Order of strings is now undefined.
True but not necessary if the strings are for hexdump convenience only and the reverse-offsets get f […]
Done
https://review.coreboot.org/c/coreboot/+/47602/4/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/47602/4/Makefile.inc@533 PS4, Line 533: idstrings
nit: Should this also be called idsection? I'm somewhat confused why there are two different names. […]
Done
https://review.coreboot.org/c/coreboot/+/47602/4/Makefile.inc@534 PS4, Line 534: COREBOOT_VERSION: $(KERNELVERSION)
Should put quotes around these just in case.
Done