Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Marshall Dawson, Tim Wawrzynczak, Christian Walter, Julius Werner, Arthur Heymans, Andrey Petrov, Fred Reitberger, Yu-Ping Wu, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63375 )
Change subject: [RFC] CBMEM: Have INIT_HOOKS in every stage ......................................................................
Patch Set 2:
(6 comments)
File src/include/cbmem.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145499): https://review.coreboot.org/c/coreboot/+/63375/comment/dc22b4e7_76663ab3 PS2, Line 110: #define _CBMEM_INIT_HOOK_UNUSED(init_fn_) __attribute__((unused)) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145499): https://review.coreboot.org/c/coreboot/+/63375/comment/bdf1b578_5c50fb13 PS2, Line 113: #define _CBMEM_INIT_HOOK(init_fn_) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145499): https://review.coreboot.org/c/coreboot/+/63375/comment/1984002a_c1a6e7fe PS2, Line 119: #define _CBMEM_INIT_HOOK_EARLY(init_fn_) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145499): https://review.coreboot.org/c/coreboot/+/63375/comment/1cfd9c9b_0c8061f6 PS2, Line 124: #define CBMEM_CREATION_HOOK(x) _CBMEM_INIT_HOOK(x) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145499): https://review.coreboot.org/c/coreboot/+/63375/comment/ab0eb13c_fb08517a PS2, Line 126: #define CBMEM_CREATION_HOOK(x) _CBMEM_INIT_HOOK_UNUSED(x) please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145499): https://review.coreboot.org/c/coreboot/+/63375/comment/c71a18c0_9bdf4e95 PS2, Line 130: #define CBMEM_INIT_HOOK(x) _CBMEM_INIT_HOOK(x) please, no space before tabs