Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42097/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42097/3//COMMIT_MSG@9 PS3, Line 9: were
I’d use present tense.
Done
https://review.coreboot.org/c/coreboot/+/42097/3//COMMIT_MSG@10 PS3, Line 10: was
is
Done
https://review.coreboot.org/c/coreboot/+/42097/3//COMMIT_MSG@11 PS3, Line 11:
Please roughly mention, that there is no audio device, and that OHCI is outdated. […]
Mentioned about lack of audio device and OHCI. AFAIK table was copy-pasted and that's why it is not suitable for a particular apu platform.
https://review.coreboot.org/c/coreboot/+/42097/3/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42097/3/src/mainboard/pcengines/apu... PS3, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00,
This should be a separate commit. There are more occurrences. […]
Those changes are introduced in CB:42388