[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus/variants/fleex: Remove NC GPIO_138 and GPIO_139 set...

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35881 )

Change subject: mb/google/octopus/variants/fleex: Remove NC GPIO_138 and GPIO_139 setting to fix EMR function
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/fleex/gpio.c:

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
PS1, Line 29: 	PAD_NC(GPIO_138, UP_20K),
It seems to me there is no one leveraged GPIO_138?

https://review.coreboot.org/c/coreboot/+/35881/1/src/mainboard/google/octopu... 
PS1, Line 32: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD),
I checked the original review comment but it is still wried to me that 
    - you put default state as low ->NMOS -> high then PEN_RESET_ODL is not active so chip is not in RESET state (???) during the boot up.
    - you set IOSTATE to high -> NMOS -> low so PEN_RESET_ODL is in active which hold chip is RESET state.