29 Jun
2018
29 Jun
'18
5:54 p.m.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/27268 )
Change subject: stoneyridge: Enable legacy IO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27268/1/src/soc/amd/stoneyridge/southbridge.... File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/#/c/27268/1/src/soc/amd/stoneyridge/southbridge.... PS1, Line 378: static void sb_enable_legacy_io(void)
I did, but wanted to call out the fact that they are different io ranged. […]
I think it's fine, I was just curious why you split them.
--
To view, visit https://review.coreboot.org/27268
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I533226ba764f567e348577d7fcf6ebe43336609a
Gerrit-Change-Number: 27268
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 29 Jun 2018 15:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No