Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30990 )
Change subject: soc/apollolake: Generate DMAR table ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c File src/soc/intel/apollolake/acpi.c:
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@194 PS5, Line 194: in 32-bit space. */ The 32-bit limitation was only a workaround for the signature of acpi_create_dmar_drhd(); which uses an uint64_t by now. So it would make more sense to read the full 64-bit register now and don't check for the upper bits to be zero.
https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@247 PS5, Line 247: !(MCHBAR32(DEFVTBAR) & VTBAR_ENABLED)) Why only check DEFVTBAR here?
Also, please don't align with the `if` body. Use 4 spaces or 2 tabs.