Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36823 )
Change subject: soc/amd/stoneyridge/kconfig: Make Prairie Falcon selection explicit
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36823/1/src/soc/amd/stoneyridge/Mak...
File src/soc/amd/stoneyridge/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36823/1/src/soc/amd/stoneyridge/Mak...
PS1, Line 140: ifeq ($(CONFIG_HAVE_MERLINFALCON_BINARIES),y)
This section might need expansion, as you could declare Prairie Falcon and have Merlin Falcon binaries. It's also important for the future when "have binaries" becomes not important.
Will add change once first code review happens.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36823
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I309c5918fdc98d9927641466bbe6149b97b250f0
Gerrit-Change-Number: 36823
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 13 Nov 2019 19:32:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment