Attention is currently required from: Cliff Huang, Felix Held, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option ......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi_apic.c:
https://review.coreboot.org/c/coreboot/+/82642/comment/e16f5ab6_05104d78?usp... : PS1, Line 130: ACPI_HAVE_PCAT_8259
i'm not sure what you mean here. […]
the spec says this in the explanation of the SCI_INT FADT field: "System vector the SCI interrupt is wired to in 8259 mode. On systems that do not contain the 8259, this field contains the Global System interrupt number of the SCI interrupt." there's also this explanation in the interrupt source override structure "You must have an interrupt source override entry for the IRQ mapped to the SCI interrupt if this IRQ is not identity mapped. This entry will override the value in SCI_INT in FADT. For example, if SCI is connected to IRQ 9 in PIC mode and IRQ 9 is connected to INTIN11 in APIC mode, you should have 9 in SCI_INT in the FADT and an interrupt source override entry mapping IRQ 9 to INTIN11.". so while this part of the code does look rather odd, this seems to be correct. i guess those are also the sections of the acpi spec referenced in src/arch/x86/acpi.c