Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43958 )
Change subject: soc/mediatek/mt8192: Add PLL and clock init support
......................................................................
Patch Set 1:
@jwerner, do you think it's fine to waive the 96-column for this file? I feel keeping the mux def in one line would improve readability.
Yes, the line length limit is a strong recommendation. In special cases where readability would be much better with overlong lines and there's no good alternative, it is allowed to ignore it. I think tables like these would qualify.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43958
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia49342c058577e8e107b7e56c867bf21532e40d2
Gerrit-Change-Number: 43958
Gerrit-PatchSet: 1
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-Comment-Date: Mon, 27 Jul 2020 23:49:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment