Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36343 )
Change subject: payloads/external/GRUB2: fix constantly rebuilding due to git checkout
......................................................................
Patch Set 2: Code-Review+2
Is it possible that the old version maintained local changes and the
new doesn't? If so, that could lead to a lot of frustration for users
that are used to it.
hm, possible but frustrating, too, because one needs to handle merge conflicts while running `make`
Yeah, just saying we might break somebody's workflow. We could try to
handle it more nicely. For instance, issue a warning if the index/tree
aren't clean and skip the checkout in that case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cf66f63268de973a654146a0a47c3d5ca516d4d
Gerrit-Change-Number: 36343
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 31 Oct 2019 22:09:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment