build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33616 )
Change subject: kodama: add a new configuration for Kodama. ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... File src/mainboard/google/kukui/panel_kodama.c:
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 69: {INIT_DCS_CMD, 1, {0x11} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 69: {INIT_DCS_CMD, 1, {0x11} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 70: {DELAY_CMD, 800, {} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 70: {DELAY_CMD, 800, {} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 71: {INIT_DCS_CMD, 2, {0x36, 0x03} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 71: {INIT_DCS_CMD, 2, {0x36, 0x03} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 72: {INIT_DCS_CMD, 1, {0x29} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 72: {INIT_DCS_CMD, 1, {0x29} }, please, no spaces at the start of a line
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 73: {DELAY_CMD, 20, {} }, code indent should use tabs where possible
https://review.coreboot.org/#/c/33616/2/src/mainboard/google/kukui/panel_kod... PS2, Line 73: {DELAY_CMD, 20, {} }, please, no spaces at the start of a line