Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32876 )
Change subject: Add support for Hygon Dhyana processor ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Welcome to the coreboot community. I am looking forward to your contributions.
https://review.coreboot.org/#/c/32876/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@7 PS1, Line 7: Add support for Hygon Dhyana processor : : src/arch/x86/cpu.c: Add hygon vendor string verify. Please collapse both lines to one commit message summary.
arch/x86/cpu: Add define and strings for Hygon
https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@11 PS1, Line 11: Background: : Chengdu Haiguang IC Design Co., Ltd (Hygon) is a Joint Venture : between AMD and Haiguang Information Technology Co.,Ltd., aims at : providing high performance x86 processor for China server market. : Its first generation processor codename is Dhyana, which : originates from AMD technology and shares most of the : architecture with AMD's family 17h, but with different CPU Vendor : ID("HygonGenuine")/Family series number(Family 18h). Maybe remove *Background:*, and remove the indentation.
https://review.coreboot.org/#/c/32876/1//COMMIT_MSG@17 PS1, Line 17: but with different CPU Vendor : ID("HygonGenuine")/Family series number(Family 18h) Please add a space before the opening (.