[coreboot-gerrit] Change in coreboot[master]: security/vboot: Decouple measured boot from verified boot

[Bill XIE (Code Review)]

Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35077 )

Change subject: security/vboot: Decouple measured boot from verified boot
......................................................................

Patch Set 71:

(3 comments)
> If it helps, we could probably call the early TCPA log a "PCR cache"?

This is just how I call it personally.

https://review.coreboot.org/c/coreboot/+/35077/70/src/security/tpm/tspi/crtm... 
File src/security/tpm/tspi/crtm.c:

https://review.coreboot.org/c/coreboot/+/35077/70/src/security/tpm/tspi/crtm... 
PS70, Line 30: static const char * const fmap_cbfs_names[] = {
             : 	"COREBOOT",
             : 	"FW_MAIN_A",
             : 	"FW_MAIN_B",
             : 	"RW_LEGACY"};
> this isn't really compliant with the code style. How about: […]

Done. It is actually a left-behind.

https://review.coreboot.org/c/coreboot/+/35077/70/src/security/tpm/tspi/tspi... 
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/c/coreboot/+/35077/70/src/security/tpm/tspi/tspi... 
PS70, Line 235: 		printk(BIOS_DEBUG, "TPM: Extending digest for"
> This string fits in one line without breaking (96-char limit)

Done

https://review.coreboot.org/c/coreboot/+/35077/70/src/security/tpm/tspi/tspi... 
PS70, Line 302: "measur" : "logg"
> Ehm, I don't think saving two characters is that much of a big deal... […]

Done