[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update chip files

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37783 )

Change subject: soc/intel/tigerlake: Update chip files
......................................................................

Patch Set 30:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch... 
File src/soc/intel/tigerlake/chip.h:

https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch... 
PS22, Line 135: /* Need to update DLL setting to get Emmc running at HS400 speed */
              : 	uint8_t EmmcUseCustomDlls;
              : 	uint32_t EmmcTxCmdDelayRegValue;
              : 	uint32_t EmmcTxDataDelay1RegValue;
              : 	uint32_t EmmcTxDataDelay2RegValue;
              : 	uint32_t EmmcRxCmdDataDelay1RegValue;
              : 	uint32_t EmmcRxCmdDataDelay2RegValue;
              : 	uint32_t EmmcRxStrobeDelayRegValue;
> EmmcUseCustomDlls is required in case we want to configure custom DLL values from FSP instead of pla […]

Just curious: Are you expecting FSP to do different things based on the values that coreboot doesn't? Basically, I am trying to understand the motivation.

In case you decide to keep this config for EmmcUseCustomDlls, would you be adding code that utilizes it in follow up CL? Can you please add appropriate comment indicating the intent of this chip config.

https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch... 
PS22, Line 145: SdCardPowerEnableActiveHigh
> Can we keep it for JSL? JSL would use this, it would not add into unused configs.

Ok, sounds good.