Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44549 )
Change subject: memory_info: Rename ddr_frequency to ddr_speed_mts
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44549/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44549/4//COMMIT_MSG@11
PS4, Line 11: 0
It's a mess. Starting in 3.1 (not 3. […]
Yes, totally agree. I guess the best option would be to bump SMBIOS version to 3.1, so that it's clear the unit is now MT/s.
I tried to do the same in CB:44013, but as it's not clear if the blobs provide units in MT/s or Mhz. Tests showed that the advertised unit is wrong, so all platforms need to be tested 1 by 1.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa75401f9fc33642dbdce6c69bd9b20f96d1cc25
Gerrit-Change-Number: 44549
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 19 Aug 2020 16:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment