13 Aug
2019
13 Aug
'19
1:52 a.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34817 )
Change subject: Add buffer_to/from_fifo32(_prefix) helpers ......................................................................
Patch Set 2:
oh, seems like coreboot mips is doing (a, v) but libpayload mips/arch/io.h is doing (v, a). I think we should fix libpayload.
Argh... bloody MIPS. I could change them all but there's still a bunch of depthcharge drivers using the current version, I don't really want to untangle them all right now. Might be best if we delete MIPS entirely instead, it's not been used by anyone and causing tons of problems for years now. I'll #ifdef it out for now and suggest that on the mailing list.
--
To view, visit https://review.coreboot.org/c/coreboot/+/34817
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf37c6d56f949f620c347df05439b05c3b8d77d
Gerrit-Change-Number: 34817
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Aug 2019 23:52:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment